Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump redisvl and fix bugs #26

Merged
merged 8 commits into from
Oct 18, 2024
Merged

Bump redisvl and fix bugs #26

merged 8 commits into from
Oct 18, 2024

Conversation

tylerhutcherson
Copy link
Collaborator

This PR bumps the supported version of RedisVL AND addresses a few bugs:

  • dtype handling within custom semantic cache vectorizer
  • float rounding errors in the integration tests

@tylerhutcherson tylerhutcherson added the bug Something isn't working label Oct 15, 2024
bsbodden
bsbodden approved these changes Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@tylerhutcherson tylerhutcherson mentioned this pull request Oct 18, 2024
Closed
@tylerhutcherson tylerhutcherson merged commit 3757d98 into langchain-ai:main Oct 18, 2024
12 checks passed
@tylerhutcherson tylerhutcherson deleted the bug/RAAE-340/bump-redisvl-fix-bugs branch October 18, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsbodden bsbodden bsbodden approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tylerhutcherson @bsbodden