core: Add ruff rules for Pylint PLC (Convention) and PLE (Errors)

libs/core/langchain_core/callbacks/manager.py

@@ -2232,9 +2232,6 @@ async def on_chain_error(
 T = TypeVar("T", CallbackManager, AsyncCallbackManager)
 
 
-H = TypeVar("H", bound=BaseCallbackHandler, covariant=True)
-
-
 def _configure(
     callback_manager_cls: type[T],
     inheritable_callbacks: Callbacks = None,

libs/core/langchain_core/document_loaders/blob_loaders.py

@@ -11,8 +11,7 @@
 from collections.abc import Iterable
 
 # Re-export Blob and PathLike for backwards compatibility
-from langchain_core.documents.base import Blob as Blob
-from langchain_core.documents.base import PathLike as PathLike
+from langchain_core.documents.base import Blob, PathLike
 
 
 class BlobLoader(ABC):

libs/core/langchain_core/messages/modifier.py

@@ -23,7 +23,7 @@ def __init__(self, id: str, **kwargs: Any) -> None:
             msg = "RemoveMessage does not support 'content' field."
             raise ValueError(msg)
 
-        return super().__init__("", id=id, **kwargs)
+        super().__init__("", id=id, **kwargs)
 
     @classmethod
     def get_lc_namespace(cls) -> list[str]:

libs/core/langchain_core/output_parsers/list.py

@@ -6,7 +6,6 @@
 from collections import deque
 from collections.abc import AsyncIterator, Iterator
 from io import StringIO
-from typing import Optional as Optional
 from typing import TypeVar, Union
 
 from langchain_core.messages import BaseMessage

libs/core/langchain_core/output_parsers/string.py

@@ -1,5 +1,3 @@
-from typing import Optional as Optional
-
 from langchain_core.output_parsers.transform import BaseTransformOutputParser
 
 

libs/core/langchain_core/prompts/pipeline.py

@@ -1,5 +1,4 @@
 from typing import Any
-from typing import Optional as Optional
 
 from pydantic import model_validator
 

libs/core/langchain_core/runnables/configurable.py

@@ -4,7 +4,6 @@
 import threading
 from abc import abstractmethod
 from collections.abc import AsyncIterator, Iterator, Sequence
-from collections.abc import Mapping as Mapping
 from functools import wraps
 from typing import (
     Any,

libs/core/langchain_core/runnables/utils.py

@@ -33,11 +33,11 @@
 from langchain_core.runnables.schema import StreamEvent
 
 # Re-export create-model for backwards compatibility
-from langchain_core.utils.pydantic import create_model as create_model
+from langchain_core.utils.pydantic import create_model  # noqa: F401
 
-Input = TypeVar("Input", contravariant=True)
+Input = TypeVar("Input", contravariant=True)  # noqa: PLC0105
 # Output type should implement __concat__, as eg str, list, dict do
-Output = TypeVar("Output", covariant=True)
+Output = TypeVar("Output", covariant=True)  # noqa: PLC0105
 
 
 async def gated_coro(semaphore: asyncio.Semaphore, coro: Coroutine) -> Any:

libs/core/langchain_core/tools/__init__.py

@@ -20,42 +20,49 @@
 from __future__ import annotations
 
 from langchain_core.tools.base import (
-    FILTERED_ARGS as FILTERED_ARGS,
-)
-from langchain_core.tools.base import (
-    BaseTool as BaseTool,
-)
-from langchain_core.tools.base import (
-    BaseToolkit as BaseToolkit,
-)
-from langchain_core.tools.base import (
-    InjectedToolArg as InjectedToolArg,
-)
-from langchain_core.tools.base import InjectedToolCallId as InjectedToolCallId
-from langchain_core.tools.base import SchemaAnnotationError as SchemaAnnotationError
-from langchain_core.tools.base import (
-    ToolException as ToolException,
-)
-from langchain_core.tools.base import (
-    _get_runnable_config_param as _get_runnable_config_param,
-)
-from langchain_core.tools.base import (
-    create_schema_from_function as create_schema_from_function,
+    FILTERED_ARGS,
+    BaseTool,
+    BaseToolkit,
+    InjectedToolArg,
+    InjectedToolCallId,
+    SchemaAnnotationError,
+    ToolException,
+    _get_runnable_config_param,
+    create_schema_from_function,
 )
 from langchain_core.tools.convert import (
-    convert_runnable_to_tool as convert_runnable_to_tool,
+    convert_runnable_to_tool,
+    tool,
 )
-from langchain_core.tools.convert import tool as tool
-from langchain_core.tools.render import ToolsRenderer as ToolsRenderer
 from langchain_core.tools.render import (
-    render_text_description as render_text_description,
+    ToolsRenderer,
+    render_text_description,
+    render_text_description_and_args,
 )
-from langchain_core.tools.render import (
-    render_text_description_and_args as render_text_description_and_args,
-)
-from langchain_core.tools.retriever import RetrieverInput as RetrieverInput
 from langchain_core.tools.retriever import (
-    create_retriever_tool as create_retriever_tool,
+    RetrieverInput,
+    create_retriever_tool,
 )
-from langchain_core.tools.simple import Tool as Tool
-from langchain_core.tools.structured import StructuredTool as StructuredTool
+from langchain_core.tools.simple import Tool
+from langchain_core.tools.structured import StructuredTool
+
+__all__ = [
+    "BaseTool",
+    "BaseToolkit",
+    "FILTERED_ARGS",
+    "SchemaAnnotationError",
+    "ToolException",
+    "InjectedToolArg",
+    "InjectedToolCallId",
+    "_get_runnable_config_param",
+    "create_schema_from_function",
+    "convert_runnable_to_tool",
+    "tool",
+    "ToolsRenderer",
+    "render_text_description",
+    "render_text_description_and_args",
+    "RetrieverInput",
+    "create_retriever_tool",
+    "Tool",
+    "StructuredTool",
+]

libs/core/pyproject.toml

@@ -44,7 +44,7 @@ python = ">=3.12.4"
 [tool.poetry.extras]
 
 [tool.ruff.lint]
-select = [ "ASYNC", "B", "C4", "COM", "DJ", "E", "EM", "EXE", "F", "FLY", "FURB", "I", "ICN", "INT", "LOG", "N", "NPY", "PD", "PIE", "Q", "RSE", "S", "SIM", "SLOT", "T10", "T201", "TID", "UP", "W", "YTT",]
+select = [ "ASYNC", "B", "C4", "COM", "DJ", "E", "EM", "EXE", "F", "FLY", "FURB", "I", "ICN", "INT", "LOG", "N", "NPY", "PD", "PIE", "PLC","PLE", "Q", "RSE", "S", "SIM", "SLOT", "T10", "T201", "TID", "UP", "W", "YTT",]
 ignore = [ "COM812", "UP007", "W293", "S101", "S110", "S112",]
 
 [tool.coverage.run]

libs/core/tests/unit_tests/language_models/chat_models/test_rate_limiting.py

@@ -1,5 +1,4 @@
 import time
-from typing import Optional as Optional
 
 from langchain_core.caches import InMemoryCache
 from langchain_core.language_models import GenericFakeChatModel

libs/core/tests/unit_tests/output_parsers/test_base_parsers.py

@@ -1,7 +1,5 @@
 """Module to test base parser implementations."""
 
-from typing import Optional as Optional
-
 from langchain_core.exceptions import OutputParserException
 from langchain_core.language_models import GenericFakeChatModel
 from langchain_core.messages import AIMessage

libs/core/tests/unit_tests/runnables/test_runnable_events_v1.py

@@ -4,7 +4,6 @@
 from collections.abc import AsyncIterator, Sequence
 from itertools import cycle
 from typing import Any, cast
-from typing import Optional as Optional
 
 import pytest
 from pydantic import BaseModel