Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openai[patch]: move test #24552

Merged
merged 3 commits into from
Jul 23, 2024
Merged

openai[patch]: move test #24552

merged 3 commits into from
Jul 23, 2024

Conversation

ccurme
Copy link
Collaborator

@ccurme ccurme commented Jul 23, 2024

No-override tests (#24407) include a condition that integrations not implement additional tests.

@ccurme ccurme requested a review from efriis July 23, 2024 14:02
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 23, 2024
Copy link

vercel bot commented Jul 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 2:16pm

@dosubot dosubot bot added the 🤖:improvement Medium size change to existing code to handle new use-cases label Jul 23, 2024
@eyurtsev
Copy link
Collaborator

@ccurme Why should we allow integrations to provide additional tests? They can create an extra test suite for that purpose?

@ccurme
Copy link
Collaborator Author

ccurme commented Jul 23, 2024

@ccurme Why should we allow integrations to provide additional tests? They can create an extra test suite for that purpose?

I guess it's a small convenience so we keep track of what model / parameters are tested in one place. But will update to move it to the openai-specific tests.

@eyurtsev
Copy link
Collaborator

I suspect it'll be good to separate them -- a bit extra work, but then it becomes easier to identify the additional tests

@efriis efriis added the partner label Jul 23, 2024
@efriis efriis self-assigned this Jul 23, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jul 23, 2024
@ccurme ccurme changed the title standard-tests[patch]: relax no overrides test openai[patch]: move test Jul 23, 2024
@ccurme ccurme merged commit a197a8e into master Jul 23, 2024
32 of 33 checks passed
@ccurme ccurme deleted the cc/update_standard_test branch July 23, 2024 14:22
olgamurraft pushed a commit to olgamurraft/langchain that referenced this pull request Aug 16, 2024
No-override tests (langchain-ai#24407)
include a condition that integrations not implement additional tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:improvement Medium size change to existing code to handle new use-cases partner size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants