-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openai[patch]: move test #24552
openai[patch]: move test #24552
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@ccurme Why should we allow integrations to provide additional tests? They can create an extra test suite for that purpose? |
I guess it's a small convenience so we keep track of what model / parameters are tested in one place. But will update to move it to the openai-specific tests. |
I suspect it'll be good to separate them -- a bit extra work, but then it becomes easier to identify the additional tests |
This reverts commit e1c1d00.
No-override tests (langchain-ai#24407) include a condition that integrations not implement additional tests.
No-override tests (#24407) include a condition that integrations not implement additional tests.