Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding Docs for new SQLServer Vector store package #28173

Merged
merged 27 commits into from
Dec 10, 2024

Conversation

Pookam90
Copy link
Contributor

Description: Adding Documentation for new SQL Server Vector Store Package.

Changed files -
Added new Vector Store - docs\docs\integrations\vectorstores\sqlserver.ipynb
FeatureTable.Js - docs\src\theme\FeatureTables.js
Microsoft.mdx - docs\docs\integrations\providers\microsoft.mdx

Detailed documentation on API - https://python.langchain.com/api_reference/sqlserver/index.html

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 3:00am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Ɑ: vector store Related to vector store module 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Nov 18, 2024
@Pookam90
Copy link
Contributor Author

@baskaryan I am getting vercel deployment error for unrelated files I havent changed or touched https://langchain-hyca809rb-langchain.vercel.app

Could you help us with fixing this?

Error: MDX compilation failed for file "/vercel/path0/docs/docs/langserve.md"
Cause: Docs markdown link couldn't be resolved: (MIGRATION.md) in source file "/vercel/path0/docs/docs/langserve.md" for version current
Details:
Error: Docs markdown link couldn't be resolved: (MIGRATION.md) in source file "/vercel/path0/docs/docs/langserve.md" for version current
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
make: *** [Makefile:88: vercel-build] Error 1
error Command failed with exit code 2.

@JANHMS
Copy link
Contributor

JANHMS commented Nov 18, 2024

@baskaryan I am getting vercel deployment error for unrelated files I havent changed or touched https://langchain-hyca809rb-langchain.vercel.app

Could you help us with fixing this?

Error: MDX compilation failed for file "/vercel/path0/docs/docs/langserve.md" Cause: Docs markdown link couldn't be resolved: (MIGRATION.md) in source file "/vercel/path0/docs/docs/langserve.md" for version current Details: Error: Docs markdown link couldn't be resolved: (MIGRATION.md) in source file "/vercel/path0/docs/docs/langserve.md" for version current error Command failed with exit code 1. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. make: *** [Makefile:88: vercel-build] Error 1 error Command failed with exit code 2.

I had the same in my PR and I think other PRs have the same issue.
#28157

@Pookam90
Copy link
Contributor Author

@baskaryan requesting help on this Vercel Failure

@yorek
Copy link

yorek commented Nov 27, 2024

@efriis can you please help to have the PR unblocked? Thanks!

@Pookam90
Copy link
Contributor Author

Pookam90 commented Dec 3, 2024

@eyurtsev @efriis could you help us with unblocking this PR please?

Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance you could get rid of the huge vector in this?

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 10, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Dec 10, 2024
@efriis efriis enabled auto-merge (squash) December 10, 2024 02:51
Copy link
Member

@efriis efriis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference this took a bit of work to get across the finish line! I think your editor might be adding some unusual html tags to the markdown cells (with style= vscode styling), as well as some issues with the format of the doc (huge embeddings, etc.).

Excited to work together, and just for future docs PRs! ^

@dosubot dosubot bot added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Dec 10, 2024
@efriis efriis merged commit 9b7d49f into langchain-ai:master Dec 10, 2024
13 checks passed
@yorek
Copy link

yorek commented Dec 10, 2024

Thanks a lot for the help Erick! Noted about the formatting issues, we'll double check next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PR looks good. Use to confirm that a PR is ready for merging. size:XL This PR changes 500-999 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants