-
Notifications
You must be signed in to change notification settings - Fork 16k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Tilores provider and tools #29244
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like maintainers don't have permission to edit this PR. Would you mind adding
- name: tilores-langchain
path: .
repo: tilotech/tilores-langchain
downloads: 0
to the bottom of packages.yml? (The downloads will be auto-populated in the docs.)
Other than that, there are what look like secret strings in the docs, these should be sanitized.
")\n", | ||
"os.environ[\"TILORES_CLIENT_ID\"] = \"3l3i0ifjurnr58u4lgf0eaeqa3\"\n", | ||
"os.environ[\"TILORES_CLIENT_SECRET\"] = (\n", | ||
" \"1c0g3v0u7pf1bvb7v65pauqt6s0h3vkkcf9u232u92ov3lm4aun2\"\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this an actual secret? we should scrub this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are public read-only credentials for a demo instance to ensure a quick and easy start without the need to sign-up and configure first. We would prefer to keep them, but if you insist we could put them into our docs and only refer from here.
"os.environ[\"TILORES_CLIENT_ID\"] = \"3l3i0ifjurnr58u4lgf0eaeqa3\"\n", | ||
"os.environ[\"TILORES_CLIENT_SECRET\"] = (\n", | ||
" \"1c0g3v0u7pf1bvb7v65pauqt6s0h3vkkcf9u232u92ov3lm4aun2\"\n", | ||
")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these sensitive? suggest using placeholder values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are public read-only credentials for a demo instance to ensure a quick and easy start without the need to sign-up and configure first. We would prefer to keep them, but if you insist we could put them into our docs and only refer from here.
Description: This PR adds documentation for the Tilores provider and tools.
Issue: closes #26320