Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Tilores provider and tools #29244

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stefan-berkner-tilotech

Description: This PR adds documentation for the Tilores provider and tools.
Issue: closes #26320

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchain ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 9:59am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Jan 16, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like maintainers don't have permission to edit this PR. Would you mind adding

- name: tilores-langchain
  path: .
  repo: tilotech/tilores-langchain
  downloads: 0

to the bottom of packages.yml? (The downloads will be auto-populated in the docs.)

Other than that, there are what look like secret strings in the docs, these should be sanitized.

")\n",
"os.environ[\"TILORES_CLIENT_ID\"] = \"3l3i0ifjurnr58u4lgf0eaeqa3\"\n",
"os.environ[\"TILORES_CLIENT_SECRET\"] = (\n",
" \"1c0g3v0u7pf1bvb7v65pauqt6s0h3vkkcf9u232u92ov3lm4aun2\"\n",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this an actual secret? we should scrub this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are public read-only credentials for a demo instance to ensure a quick and easy start without the need to sign-up and configure first. We would prefer to keep them, but if you insist we could put them into our docs and only refer from here.

Comment on lines +79 to +82
"os.environ[\"TILORES_CLIENT_ID\"] = \"3l3i0ifjurnr58u4lgf0eaeqa3\"\n",
"os.environ[\"TILORES_CLIENT_SECRET\"] = (\n",
" \"1c0g3v0u7pf1bvb7v65pauqt6s0h3vkkcf9u232u92ov3lm4aun2\"\n",
")"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these sensitive? suggest using placeholder values

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are public read-only credentials for a demo instance to ensure a quick and easy start without the need to sign-up and configure first. We would prefer to keep them, but if you insist we could put them into our docs and only refer from here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:docs Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

DOC: Add tooling for Tilores entity resolution SDK
2 participants