Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

community(doc_loaders): allow any credential type in AzureAIDocumentI… #29289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ianchi
Copy link
Contributor

@ianchi ianchi commented Jan 18, 2025

allow any credential type in AzureAIDocumentInteligence, not only api_key.
This allows to use any of the credentials types integrated with AD.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 18, 2025
Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jan 18, 2025 4:46pm

@dosubot dosubot bot added community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) labels Jan 18, 2025
Copy link
Collaborator

@ccurme ccurme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@@ -24,6 +29,7 @@ def __init__(
mode: str = "markdown",
*,
analysis_features: Optional[List[str]] = None,
credentials: Optional["TokenCredential"] = None,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we name this azure_credential, for consistency with what was done here: #28873

@ccurme ccurme self-assigned this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community Ɑ: doc loader Related to document loader module (not documentation) size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

2 participants