Fix for sending notifications with include_external_user_ids #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was having an issue when using include_external_user_ids; The OneSignal API was returning an error: `Platforms You may only send to one delivery channel at a time. Make sure you are only including one of push platforms, isEmail, or isSms.` This is fixed by setting channel_for_external_user_ids to Push, so the API knows which players to send. This is a quick fix, but could possibly be made configurable.
Jahyrm
reviewed
Nov 24, 2021
There was a problem hiding this comment.
This problem can be solved adding this to the create() method:
OneSignalMessage::create()
...
->setParameter('channel_for_external_user_ids', 'push')
...;
Where "push" can be change for: "email" or "sms" when sending to that channel. Remember you can make a call to one channel at a time.
mhuryanov
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having an issue when using include_external_user_ids; The OneSignal API was returning an error:
Platforms You may only send to one delivery channel at a time. Make sure you are only including one of push platforms, isEmail, or isSms.This is fixed by setting channel_for_external_user_ids to Push, so the API knows which players to send.
This is a quick fix, but could possibly be made configurable.