Merge pull request #1011 from leethomason/leethomason/charref2

Defensive check for UTF conversion
leethomason · Dec 10, 2024 · 57ec941 · 57ec941
2 parents 4cbb251 + 1fadaae
commit 57ec941
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/tinyxml2.cpp b/tinyxml2.cpp
@@ -545,6 +545,11 @@ const char* XMLUtil::GetCharacterRef(const char* p, char* value, int* length)
         }
         // convert the UCS to UTF-8
         ConvertUTF32ToUTF8(ucs, value, length);
+		if (length == 0) {
+            // If length is 0, there was an error. (Security? Bad input?)
+            // Fail safely.
+			return 0;
+		}
         return p + delta + 1;
     }
     return p + 1;