Lem SDL2 can now properly display zero-width characters. #1739
+30
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if someone tried to open a file that contains zero-width characters, such as `U+200B`, `U+200C`, `U+200D`, and `U+FEFF`, Lem SDL2 will just refuse to display any content, leaving the user with a blank window. This is probably because SDL2 does not like zero-width characters. So now I try to fix this problem by adding another `char-type` dedicated for zero-width characters, and display them with a special character. I've also created a new attribute for zero-width characters and control characters, so users won't confuse them with real contents.
|
I think this may be a relative issue, would you like to test it? |
Interesting, it seems Lem just hang instead of giving out that SDL error while reproducing this issue. Maybe there are other weird characters in these documents which cause these problems.
|
|
So I just checked if Lem can now open the file that I wanted to open, turns out it still gives out the same zero-width error from SDL2. So I went to see what kind of characters this document has, it turns out it does not contain any zero-width character AT ALL, then it must be some other character causing the issue. The document: https://raw.githubusercontent.com/dannyvankooten/1brc/refs/heads/main/README.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if someone tried to open a file that contains zero-width characters, such as
U+200B,U+200C,U+200D, andU+FEFF, Lem SDL2 will just refuse to display any content, leaving the user with a blank window. This is probably because SDL2 does not like zero-width characters.So now I try to fix this problem by adding another
char-typededicated for zero-width characters, and display them with a special character.I've also created a new attribute for zero-width characters and control characters, so users won't confuse them with real contents.