Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dcutr): fix typo in log statement #4854

Merged
merged 3 commits into from
Nov 14, 2023

Conversation

stormshield-frb
Copy link
Contributor

@stormshield-frb stormshield-frb commented Nov 13, 2023

Description

Fixes: #4853.

Notes & open questions

N/A

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@stormshield-frb stormshield-frb changed the title fix(dcutr) : fix small typo in dcutr log fix(dcutr): fix small typo in dcutr log Nov 13, 2023
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stormshield-frb
Copy link
Contributor Author

Since this is a private change, I did not made a CHANGELOG entry. But not doing so result in an error for the check Continuous integration / Test libp2p-dcutr (pull_request). Not sure what I am supposed to do in this kind of situation :)

@thomaseizinger
Copy link
Contributor

Since this is a private change, I did not made a CHANGELOG entry. But not doing so result in an error for the check Continuous integration / Test libp2p-dcutr (pull_request). Not sure what I am supposed to do in this kind of situation :)

Your thinking is correct!

We can adjust the PR title to say chore instead. For these kind of changes (and refactor), the changelog check is skipped :)

@thomaseizinger thomaseizinger changed the title fix(dcutr): fix small typo in dcutr log chore(dcutr): fix typo in log statement Nov 14, 2023
@mergify mergify bot merged commit bfeb8c9 into libp2p:master Nov 14, 2023
71 checks passed
@stormshield-frb stormshield-frb deleted the fix/dcutr-log-typo branch November 27, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect log in dcutr
3 participants