Merge pull request #15227 from brollin/improve-keyboard-move-testing

Improve keyboard move testing
lichess-org · May 6, 2024 · a28ab6b · a28ab6b
2 parents d599a8a + e587a5d
commit a28ab6b
Show file tree

Hide file tree

Showing 10 changed files with 834 additions and 1,097 deletions.
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/ui/README.md b/ui/README.md
@@ -29,15 +29,6 @@ cd ui/
 pnpm test
 ```
 
-### VSCode
-
-The Jest extension is your friend. You will want to configure the following in your `settings.json`:
-
-```
-"jest.rootPath": "ui",
-"jest.jestCommandLine": "node_modules/.bin/jest --config jest.config.js",
-```
-
 ## CSS
 
 The structure of a CSS module is as follows:

diff --git a/ui/jest.config.js b/ui/jest.config.js
@@ -1,9 +1,9 @@
 /* eslint-env node */
 module.exports = {
   testMatch: ['**/dist/**/*.test.js'],
-  testEnvironment: 'jsdom',
+  testEnvironment: 'node',
   transform: {},
   globals: {
-    lichess: {},
+    site: {},
   },
 };
diff --git a/ui/keyboardMove/src/ctrl.ts b/ui/keyboardMove/src/ctrl.ts
@@ -1,4 +1,5 @@
 import * as cg from 'chessground/types';
+import { SanToUci } from 'chess';
 import { h } from 'snabbdom';
 import { onInsert } from 'common/snabbdom';
 import { promote } from 'chess/promotion';
@@ -24,6 +25,7 @@ export interface KeyboardMove {
   hasSelected(): cg.Key | undefined;
   confirmMove(): void;
   usedSan: boolean;
+  legalSans: SanToUci | null;
   arrowNavigate(arrowKey: ArrowKey): void;
   justSelected(): boolean;
   draw(): void;
@@ -128,6 +130,7 @@ export function ctrl(root: KeyboardMoveRootCtrl): KeyboardMove {
     hasSelected: () => cg.state.selected,
     confirmMove: () => (root.submitMove ? root.submitMove(true) : null),
     usedSan,
+    legalSans: null,
     arrowNavigate(arrowKey: ArrowKey) {
       if (root.handleArrowKey) {
         root.handleArrowKey?.(arrowKey);