Fix: Correspondence confirm move behavior #1329 #1348
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed because of a dart formatting error in test, submitted new PR with formatting fixed. |
|
FYI, it's totally fine (and probably preferred) to push additional commits (or use `git commit --amend) instead of opening a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug #1329
Confirm move dialog does not disappeared when back arrow is pressed to visualize previous positions (it disappears correctly in web app). It's a problem not only related to correspondence chess, but to all time controls where "Move confirmation" preference is set.
To fix it, an additional condition is added (in GamePlayer widget) to show the ConfirmMove widget: 'canGoForward ==false' (the same condition used to disable the forward button). To achieve this, an additional parameter 'canGoForward' is added to the GamePlayer widget constructor..