Fix/german translation #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bellisk
force-pushed
the
fix/german-translation
branch
2 times, most recently
from
b1ca9c4 to
1c0adc4
Compare
stefina
approved these changes
Nov 7, 2024
The German translation for this string in CKAN contains an extra variable that is not in the original string. This causes an error on viewing some dataset activities.
bellisk
force-pushed
the
fix/german-translation
branch
from
4d2d7a7 to
6e1aa42
Compare
This template is here not to be overriden, but so that when we update our translation files, we keep the translations in the template. This is necessary because one of the translations is wrong in CKAN core and causes an error when the template is used.
bellisk
commented
Nov 7, 2024
Comment on lines
-451
to
-457
| #: ckanext/switzerland/templates/package/snippets/resource_item.html:25 | ||
| msgid "Preview" | ||
| msgstr "" | ||
|
|
||
| #: ckanext/switzerland/templates/package/snippets/resource_item.html:28 | ||
| msgid "More information" | ||
| msgstr "" |
There was a problem hiding this comment.
these strings were removed from the template because we now just invoke {{ super() }} where they were.
bellisk
commented
Nov 7, 2024
Comment on lines
+668
to
+675
| #: ckanext/switzerland/templates/snippets/changes/resource_extras.html:87 | ||
| msgid "" | ||
| "Changed value of field <q>{key}</q> to <q>{new_val}</q> in resource " | ||
| "{resource_link} in {pkg_link}" | ||
| msgstr "" | ||
| "Wert des Feldes <q>{key}</q> wurde geändert zu <q>{new_val}</q> in der " | ||
| "Ressource {resource_link} in {pkg_link}" | ||
|
|
There was a problem hiding this comment.
this is the string that is translated wrongly in CKAN and causes errors (the msgstr has an extra variable that is not in the msgid). Double checked that this is our correct translation. ;)
stefina
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.