Feat/update to ckan 2.10 python 3 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bellisk
force-pushed
the
feat/update-to-ckan-2.10-python-3
branch
2 times, most recently
from
8b4b184 to
31c3aec
Compare
stefina
approved these changes
Aug 23, 2023
These templates were only overridden to use the bs3-confirm-action.js module, which has now been removed.
These templates were only overridden to use the bs3-confirm-action.js module, which has now been removed.
bs3-image-upload.js replicates the current image-upload.js module less nice functionality and is unnecessary now.
This macro was only overridden to use the bs3-image-upload.js module, which has now been removed.
bs3-resource-reorder.js replicates the current resource-reorder.js module less nice functionality and is unnecessary now.
This template was only overridden to use the bs3-confirm-action.js module, which has now been removed.
This wasn't being loaded correctly and the CKAN vendor bootstrap.js was causing no problems, so out it goes.
Our changes to these templates are obsolete with CKAN 2.10
values.values() now has the type dict_values and needs to be cast to a list before being JSON-serialized.
The class 'dataset-form' is required so that our CSS can correctly style the form inputs.
I don't know why *removing* the backwards compatibility here works, but it does.
Fix/fix harvester job details
Fix/use activities js
This should prevent installation failure caused by the fact that the version of black we use requires a higher version of packaging than is installed on the test docker container. In that case, pip tries to uninstall packaging before installing our dev-requirements (including black), but the uninstallation fails because packaging was not originally installed by pip.
Fix/display that dataset is private
We need to keep backwards compatibility (which we previously removed) so that uploading files works when using ckanext-scheming.
fix: Remove override of resource upload template
Feat/change translation term
…rch-results Fix/fall back to dataset name in search results
This block can be removed from our template when ckan/ckan#8048 is merged and in use.
Feat/sort by metadata modified
…-plugin Feat/remove references to hrf faq wp plugin
This does not affect the tests on github as we ensure the test-core.ini location is set correctly before running tests there.
Tests/update test core ini location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.