New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assign a value to scope.hammerTime before using it to avoid ‘undefined’ #597

Open

hollton wants to merge 1 commit into likeastore:master from hollton:ngDialog-fs

hollton commented Mar 6, 2019

What issue is this PR resolving? Alternatively, please describe the bugfix/enhancement this PR aims to provide

The $window.Hammer is not undefined, but scope.hammerTime has been deleted and then it fails to close the dialog becase hammerTime is undefined.
This PR resolves this by Assign $window.Hammer($dialog[0]) to scope.hammerTime.


          Assign a value to it before using hammerTime to avoid undefined

b793596

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet