Skip to content

Potential shutdown subscriptions leaks #26

Description

@weidonglian

I notice the subscribe client when being closed/shutdown, it will loop a map[string]subscription and wait to close each subscription. How about if we subscribe to the same topic a couple of times in one app which could be possibly done through different modules? Then we will override the subscription in the map with the same topic and we won't gracefully shutdown.

type struct subscriptionEntry {
topic string
subscription *stan.Subscription
}

A slice []subscriptionEntryt might be good enough instead of a map.

How to do unsubscribe? I know in most cases, we do not need to.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions