Repository navigation
feat: re-vendoriza o manifest com qualification start-approval-steps e settings supplier-field field convert - #74
Merged
djalmaaraujo merged 1 commit intoOct 2, 2026
Conversation
…` e `settings supplier-field field convert` Traz o manifest da main da linkana (@89061422df), defasado desde 11/09. Entram `qualification start-approval-steps` (linkana#15630) e `settings supplier-field field convert`. `settings approval-step create` troca `--condition` por `--conditions` (repetível, composição imutável) e `settings registration update` ganha `--requires_tax_regime_confirmation`. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
cubic analysis
All reported issues were addressed across 2 files
Linked issue analysis
Linked issue: LIN-7717: CLI: qualification start-approval-steps — expor o botão Iniciar aprovações ao lk
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Expose approval-step startup as an lk command | The regenerated manifest and SURFACE.txt add qualification start-approval-steps, mapped to the start-approval-steps endpoint. |
| Starting approval steps should match the button’s behavior | The manifest describes the button-equivalent behavior, but the E2E evidence only shows one pending step being started. | |
| ✅ | Repeating the command returns already_started | The PR’s E2E run reports already_started on the repeated call, and the manifest documents that response. |
| ✅ | Report when no approval steps are triggerable | The E2E run reports no_triggerable_approval_steps, and the manifest specifies that no steps are created. |
| ✅ | Regenerate the CLI manifest rather than editing it manually | The PR says it ran make update-manifest, and the diff updates the generated manifest source and timestamp. |
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
djalmaaraujo
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Descrição
Re-vendoriza o manifest da
mainda linkana (@89061422df). A cópia vendorada estava defasada desde 11/09. Rodeimake update-manifeste atualizei o golden doSURFACE.txt.Superfície
Entram:
qualification start-approval-steps: botão "Iniciar aprovações", linkana#15630, LIN-7717.settings supplier-field field convert.Flags:
settings approval-step createtroca--conditionpor--conditions, repetível e com composição imutável. Oupdateaceita--conditions, mas ignora.settings registration updateganha--requires_tax_regime_confirmation, e--requires_supplier_registrationdeixa de ser obrigatória.Nenhum comando sai.
release-preflight --bump-onlyderiva v0.20.0 (minor, 2 comandos adicionados).Como verificar
E2E com o binário real contra a linkana local (
main, com a #15630):Par
linkanalabs/lk-stack#908: a skill
lkno contrato novo. Revisar e mergear juntos. Depois do merge, publicar a v0.20.0 pela skillrelease.🤖 Generated with Claude Code