Skip to content

feat: re-vendoriza o manifest com qualification start-approval-steps e settings supplier-field field convert - #74

Merged
djalmaaraujo merged 1 commit into
linkanalabs:mainfrom
leonardo-vsilva:leonardoventura/lin-7717-qualification-start-approval-steps
Oct 2, 2026
Merged

djalmaaraujo merged 1 commit into
linkanalabs:mainfrom
leonardo-vsilva:leonardoventura/lin-7717-qualification-start-approval-steps

Conversation

@leonardo-vsilva

Copy link
Copy Markdown
Contributor

Descrição

Re-vendoriza o manifest da main da linkana (@89061422df). A cópia vendorada estava defasada desde 11/09. Rodei make update-manifest e atualizei o golden do SURFACE.txt.

Superfície

Entram:

  • qualification start-approval-steps: botão "Iniciar aprovações", linkana#15630, LIN-7717.
  • settings supplier-field field convert.

Flags:

  • settings approval-step create troca --condition por --conditions, repetível e com composição imutável. O update aceita --conditions, mas ignora.
  • settings registration update ganha --requires_tax_regime_confirmation, e --requires_supplier_registration deixa de ser obrigatória.

Nenhum comando sai. release-preflight --bump-only deriva v0.20.0 (minor, 2 comandos adicionados).

Como verificar

make test        # verde
make lint        # 0 issues
make cover       # 95.4% (min 95.0%)
./scripts/release-preflight.sh --manifest-only   # PASS, vendorado em dia

E2E com o binário real contra a linkana local (main, com a #15630):

$ lk --skip-emails qualification start-approval-steps <qid>   → "result":"started", 1 etapa pending, exit 0
$ (repetido)                                                  → "result":"already_started", exit 0
$ (buyer sem etapa aplicável)                                 → "result":"no_triggerable_approval_steps", exit 0
$ (id inexistente)                                            → corpo 404 no stderr, exit 1
$ LK_TOKEN=lkn_bad_bad …                                      → error: token rejected (401); run `lk auth login`, exit 1
$ (sem argumento)                                             → error: accepts 1 arg(s), received 0, exit 1
$ … --format ids                                              → o id da homologação
$ lk settings approval-step create … --condition RISK_SCORE   → error: unknown flag: --condition
$ lk settings approval-step create … --conditions risk_score --conditions setting_tag → "conditions":["risk_score","setting_tag"]

Par

linkanalabs/lk-stack#908: a skill lk no contrato novo. Revisar e mergear juntos. Depois do merge, publicar a v0.20.0 pela skill release.

🤖 Generated with Claude Code

…` e `settings supplier-field field convert`

Traz o manifest da main da linkana (@89061422df), defasado desde 11/09.
Entram `qualification start-approval-steps` (linkana#15630) e
`settings supplier-field field convert`. `settings approval-step create`
troca `--condition` por `--conditions` (repetível, composição imutável) e
`settings registration update` ganha `--requires_tax_regime_confirmation`.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

All reported issues were addressed across 2 files

Linked issue analysis

Linked issue: LIN-7717: CLI: qualification start-approval-steps — expor o botão Iniciar aprovações ao lk

Status Acceptance criteria Notes
✅ Expose approval-step startup as an lk command The regenerated manifest and SURFACE.txt add qualification start-approval-steps, mapped to the start-approval-steps endpoint.
⚠️ Starting approval steps should match the button’s behavior The manifest describes the button-equivalent behavior, but the E2E evidence only shows one pending step being started.
✅ Repeating the command returns already_started The PR’s E2E run reports already_started on the repeated call, and the manifest documents that response.
✅ Report when no approval steps are triggerable The E2E run reports no_triggerable_approval_steps, and the manifest specifies that no steps are created.
✅ Regenerate the CLI manifest rather than editing it manually The PR says it ran make update-manifest, and the diff updates the generated manifest source and timestamp.

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

Comment thread internal/manifest/cli-manifest.json Resolved
Comment thread internal/manifest/cli-manifest.json Resolved
@djalmaaraujo
djalmaaraujo merged commit 5210d3d into linkanalabs:main Oct 2, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants