Repository navigation
feat: lk ganha os 11 comandos de documento do fornecedor - #78
Merged
Merged
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Adds 11 supplier document commands to the lk CLI by re-vendoring the linkana manifest; this expands the public CLI surface to sensitive review/override operations with backend side effects, so a human should approve the exposure decision.
Turn on auto-fix | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue relacionada
Parte B da LIN-8122
Descrição
O
lkpassa a ter os 11 comandos de documento do fornecedor que o linkana já expõe:supplier document list,document review,revert-review,request-update,cancel-update,expires-at,renew-ate os quatro overrides com arquivo (form-override,certificate-override,check-override,bank-information-override). Nenhum código novo: é o manifest re-vendorizado damaindo linkana, e oSURFACE.txtsó ganha linhas.O
TestLoadEmbeddedManifestexigiaidentity showcomo primeiro comando. Comdocument ...na frente em ordem alfabética, isso quebrou, então troquei pra busca por nome, igual o resto do teste já fazia.README e CLAUDE.md ainda falavam de
suppliercomo comando escrito à mão. Agora dizem que todo comando de recurso vem do manifest e citam olk upload.Depois do merge falta o release (
v0.21.0), que eu só faço com ok.Instruções de teste
make test,make lintemake cover.make builde, comLK_API_URLapontando pra um linkana local namain:./lk supplier document list <supplier_id>,./lk upload --file x.docx(content type do Word, não zip) e./lk document certificate-override <id> --state not_clear --documentable_attributes '{"file":"<signed_id>"}'.Verificação
make testverde,make lint0 issues,make cover95,5%.SURFACE.txt: 13 linhas novas (os 11 comandos e os gruposlk documentelk supplier document), nenhuma removida.main(4197aa4b8f), banco isolado com dado fictício, PAT de usuário fictício no lugar dolk impersonate:supplier document list: 200 com os ids, 404 com fornecedor de fora.lk upload:.docxsubiu comoapplication/vnd.openxmlformats-officedocument.wordprocessingml.document,.pdfcomoapplication/pdf.document certificate-overridecom o.docx: 200 com versão nova;--state informativedeu 422.document review: 200; de novo no mesmo documento deu 422 ("Documento não está aguardando revisão.").document revert-review: 200 (volta praready_to_review); em documento não revisado deu 422.