Repository navigation
Conversation
1. Bind the confirmation window width to its existing minimumWidth. 2. Preserve the fixed-width policy, layer-shell initialization and uninstall/cancel behavior; do not change public DTK components. Influence: 1. Verify uninstall confirmation display, cancel and reopen in Treeland. 2. Check the shared dialog in windowed and fullscreen launcher modes. fix: 卸载确认框实际宽度遵循已有尺寸约束 1. 将确认窗口的实际宽度绑定到现有 minimumWidth。 2. 保留固定宽度策略、layer-shell 初始化及卸载/取消行为,不修改公共 DTK 组件。 Influence: 1. 验证 Treeland 下卸载确认框显示、取消和重开。 2. 检查窗口与全屏启动器模式共用的确认框。 Log: keep uninstall confirmation at its existing fixed width PMS: BUG-383057
Reviewer's GuideUIBind the uninstall confirmation window’s actual width to its existing minimumWidth so it honors the fixed-width constraint.
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="shell-launcher-applet/package/launcheritem.qml" line_range="399" />
<code_context>
DLayerShellWindow.anchors = DLayerShellWindow.AnchorNone
}
+ width: minimumWidth
minimumWidth: layout.implicitWidth + 2 * DStyle.Style.dialogWindow.contentHMargin
minimumHeight: layout.implicitHeight + DStyle.Style.dialogWindow.titleBarHeight
</code_context>
<issue_to_address>
**Uninstall confirmation stays collapsed**
When the uninstall confirmation is opened from the launchpad on an older DTK, `qml/Main.qml`'s uninstall confirmation sets only `minimumWidth` and `maximumWidth`, so the window remains collapsed and clips its text and buttons.
Bind the uninstall confirmation's `width` to `minimumWidth` in `qml/Main.qml`.
</issue_to_address>
deepin pr auto review🤖 AI 代码审查报告📊 总体评价
🔍 详细分析1. 语法逻辑 ✅评价: 语法正确,逻辑清晰 ✅ 通过 潜在问题: 建议: 无 2. 代码质量 ✅评价: 代码结构清晰,注释完整 ✅ 通过 潜在问题: 建议: 无 3. 代码性能 ✅评价: 性能良好,资源使用合理 ✅ 通过 潜在问题: 建议: 无 4. 代码安全 🔒评价: 存在0个安全漏洞 ✅ 通过
安全漏洞详情: 建议: 无 💡 改进建议代码示例// 当前修复已正确,无需额外改进 // width: minimumWidth 确保对话框宽度遵循最小宽度约束本报告由 AI 代码审查工具自动生成 |
wjyrich
approved these changes
Nov 13, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: robertkill, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改
基于
release/2500u2的6f9a86d4b073753895182d747453c3d0bdc6455c,仅为共用卸载确认框增加:保留该分支已有的
Component.onCompletedlayer-shell 初始化,不携带 master 的主题、图标测试或其它变更;不改卸载、取消逻辑及公共 DTK。原因与适用范围
此 PR 替代原面向 master 的 #848,交付目标为 2500u2。
旧 DTK
6.7.52-1下,启动器已设 minimumWidth/maximumWidth,但对话框实际宽度仍会塌缩。此行让实际宽度遵守业务已有的固定宽度约束。DTK PR #745 的布局改动已包含在 6.7.53;同环境源码几何对照显示新实现无需此行也能达到预期宽度。因此这是兼容旧 DTK 的发布分支修复,不宣称最新 DTK 仍存在该缺陷。
实际验证
10.20.9.14的 Treeland 真实桌面临时安装libdtk6declarative 6.7.52-1,其余 DTK core/gui 保持 6.7.53.0,dde-shell 保持 2.0.61.4;实际映射 SHA-256 与安装产物一致。searchfilterproxymodeltest::testSharedModelAdapter,第 322 行 desktopId 映射断言。没有修改断言、跳过测试或夹带搜索修复。git diff --check通过。dde-launchpad 2.0.52.3、libdtk6declarative 6.7.53.1、窗口模式和桌面现场;包校验、实际映射内容及 dpkg audit 正常。未覆盖
未点击最终“确定”,没有实际卸载软件;未覆盖多屏混合缩放、长应用名/大字体、其它架构或全套旧 DTK core/gui。仅 declarative 降到旧版的组合已明确,不把它称为全套 6.7.52 环境。
Log: keep uninstall confirmation at its existing fixed width
PMS: BUG-383057
Summary by Sourcery
Bug Fixes: