Repository navigation
remote_registration.py: Fix TypeError when logging a failed cert request - #262
Open
Amadeus-22 wants to merge 1 commit into
Open
Amadeus-22 wants to merge 1 commit into
Amadeus-22 wants to merge 1 commit into
Conversation
The format string had two placeholders for three arguments, so the socket.error handler raised TypeError instead of logging the error. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
Request.request()thesocket.errorhandler formats its message with two placeholders and three arguments:so instead of logging the socket error it raises
TypeError: not all arguments converted during string formatting. This is reached during registration with a v1 peer when the UDP request fails with anything other than a timeout (for example, network unreachable).Added the missing
%s.Note: #245 removes the v1 registration code, including this line. If that is going in, feel free to close this one.
🤖 Generated with Claude Code