Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set a default name for job identity-multi-worker-test #3112

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

higherordertech
Copy link
Contributor

set a default name for job identity-multi-worker-test while identity-multi-worker-test is skipped, so we don't see ${{ matrix.test_name }}

Context

Labels

Please apply following PR-related labels when appropriate:

  • C0-breaking: if your change could break the existing client, e.g. API change, critical logic change
  • C1-noteworthy: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvement

How (Optional)

Testing Evidences

Please attach any relevant evidences if applicable

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@Kailai-Wang Kailai-Wang merged commit 5d3ab44 into dev Oct 2, 2024
25 checks passed
@Kailai-Wang Kailai-Wang deleted the fix-ci-job-name branch October 2, 2024 06:43
@Kailai-Wang
Copy link
Collaborator

Acutally, it still didn't work as far as I saw

and it seems to be an unsolved github problem: https://github.com/orgs/community/discussions/13261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants