-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: P-1044 merge all identity tests into one #3113
Conversation
4acc9f8
to
5ae3a56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having all the tests in a single place makes sense, thanks @higherordertech
Because of how ts-tests were created, I understand we need to clean up storage with clear_linked_identities
. I guess it is ok to have development-only features, but I'd have preferred to re-work ts-tests to for example use random accounts each time instead of requiring a cleanup on every run. I understand it'd be out of scope, too.
Thanks! It's good to go once CI passes - please note we expect the tests to be adjusted again to align with the omni-account usage (very soon, but the effort should not that huge) |
…the combined di identity tests
3f65aa2
to
792171e
Compare
Spot on, I updated the tests to not rely on cli to clear idgraph but just randomize new account for each test case now. |
Context
As title
Labels
Please apply following PR-related labels when appropriate:
C0-breaking
: if your change could break the existing client, e.g. API change, critical logic changeC1-noteworthy
: if your change is non-breaking, but is still worth noticing for the client, e.g. reference code improvementHow (Optional)
Testing Evidences
Please attach any relevant evidences if applicable