Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use encoded Identity for hashing #3120

Merged
merged 3 commits into from
Oct 8, 2024
Merged

Use encoded Identity for hashing #3120

merged 3 commits into from
Oct 8, 2024

Conversation

Kailai-Wang
Copy link
Collaborator

Context

As topic, we don't need to convert to string first.

@Kailai-Wang Kailai-Wang requested review from silva-fj and a team October 8, 2024 12:51
@Kailai-Wang Kailai-Wang self-assigned this Oct 8, 2024
silva-fj
silva-fj approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@silva-fj silva-fj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I didn't know Encode had this method

@Kailai-Wang Kailai-Wang merged commit 1fd1efc into dev Oct 8, 2024
25 checks passed
@Kailai-Wang Kailai-Wang deleted the use-other-hash branch October 8, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silva-fj silva-fj silva-fj approved these changes

Assignees

@Kailai-Wang Kailai-Wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kailai-Wang @silva-fj