omni-executor init
#3122
Merged
omni-executor init
#3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silva-fj
approved these changes
Oct 15, 2024
BillyWooo
reviewed
Oct 16, 2024
tee-worker/omni-executor/parentchain/artifacts/rococo-omni-account.scale
Outdated
Show resolved
Hide resolved
Kailai-Wang
reviewed
Oct 17, 2024
tee-worker/omni-executor/executor-core/src/sync_checkpoint_repository.rs
Show resolved
Hide resolved
| /// in case of substrate chain it is BLOCK_NUM::EVENT_NUM | ||
| pub trait Checkpoint { | ||
| // determines whether checkpoint is a whole block or not | ||
| fn just_block_num(&self) -> bool; |
There was a problem hiding this comment.
I find just_block_num a bit confusing :D
Does it make sense to have a CheckPointType type?
There was a problem hiding this comment.
I was thinking about it, but since it's trait we only assume there is something like 'block'.
The other improvement could look like this:
- remove
just_block_num - after restart always start syncing from
get_block_num() - 1but skip already processed events
tee-worker/omni-executor/executor-core/src/sync_checkpoint_repository.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial code for
omni-executoroffchain worker.Adds: