Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding request_intent trusted call #3143

Merged
merged 35 commits into from
Oct 25, 2024
Merged

Conversation

silva-fj
Copy link
Contributor

This PR adds the first trusted call related to the omni-account, here are some of the most important changes:

  • Since we are not using the sidechain we are now using the nonce of the parentchain for the call verifications.
  • The dispatch_as_omni_account call takes the nonce of the omni account. (Included in the TrustedCall), so this part of the verification happens on-chain.

Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, thanks. I left comments regarding nonce

Comment on lines +17 to +20
#[codec(index = 2)]
SystemRemark(BoundedVec<u8, ConstU32<MAX_REMARK_LEN>>),
#[codec(index = 3)]
TransferNative(TransferNative),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is fine for the demo, how about having a more generic CallNative(Box<RuntimeCall>)?

tee-worker/identity/enclave-runtime/src/rpc/common_api.rs Outdated Show resolved Hide resolved
parachain/pallets/omni-account/src/lib.rs Outdated Show resolved Hide resolved
@silva-fj silva-fj merged commit 3d496aa into dev Oct 25, 2024
21 checks passed
@silva-fj silva-fj deleted the adding-omni-account-trusted-calls branch October 25, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants