Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

omni-executor enclave registration #3150

Merged
merged 6 commits into from
Oct 31, 2024
Merged

Conversation

kziemianek
Copy link
Member

It uses dcap attestation method. Currently always built with sgx debug = 1

@kziemianek kziemianek requested a review from a team October 29, 2024 09:56
Copy link
Collaborator

@Kailai-Wang Kailai-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks
Have you tried it with real dcap data?

get-omni-pallet-metadata:
subxt metadata --url http://localhost:9944 --allow-insecure --pallets OmniAccount > parentchain/artifacts/rococo-omni-account.scale
.PHONY: get-pallet-metadata
get-pallet-metadata:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where exactly is this target used? I see we do refer to this file in the listener, but the build order / depedency doesn't reflect that

Copy link
Member Author

@kziemianek kziemianek Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we need to manually run it. Basically every time these pallets changes. It's not convinient and I think we will need to another strategy.

@kziemianek kziemianek enabled auto-merge (squash) October 31, 2024 08:44
@kziemianek kziemianek merged commit c5d1243 into dev Oct 31, 2024
21 checks passed
@kziemianek kziemianek deleted the omni-executor-attestation branch October 31, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants