feat: add conviction vote support #3206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: WMQ <[email protected]>
silva-fj
approved these changes
Dec 16, 2024
| name: "root", | ||
| // A limit for the number of referenda on this track that can be being decided at once. | ||
| // For Root origin this should generally be just one. | ||
| max_deciding: 5, |
There was a problem hiding this comment.
Why 5 on the root track? Shouldn’t this be 1?
There was a problem hiding this comment.
I just think in the past time we had multiple root operations simultaneously.
But you are correct, 1 will more fit DAO concept. Maybe we can rediscuss the parameter when impl it on mainnet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This impl add conviction vote related logic to paseo.