[CIR] Cleanup: convert from Clang type to CIR type #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class `CIRGenFunction` contained three identical functions that converted from a Clang AST type (`clang::QualType`) to a ClangIR type (`mlir::Type`): `convertType`, `ConvertType`, and `getCIRType`. This embarrassment of duplication needed to be fixed, along with cleaning up other functions that convert from Clang types to ClangIR types. The three functions `CIRGenFunction::ConvertType`, `CIRGenFunction::convertType`, and `CIRGenFunction::getCIRType` were combined into a single function `CIRGenFunction::convertType`. Other functions were renamed as follows: `CIRGenTypes::ConvertType` to `CIRGenTypes::convertType` `CIRGenTypes::ConvertFunctionTypeInternal` to `CIRGenTypes::convertFunctionTypeInternal` `CIRGenModule::getCIRType` to `CIRGenModule::convertType` `ConstExprEmitter::ConvertType` to `ConstExprEmitter::convertType` `ScalarExprEmitter::ConvertType` to `ScalarExprEmitter::convertType` Many cases of `getTypes().convertType(t)` and `getTypes().convertTypeForMem(t)` were changed to just `convertType(t)` and `convertTypeForMem(t)`, respectively, because the forwarding functions in `CIRGenModule` and `CIRGenFunction` make the explicit call to `getTypes()` unnecessary.
dkolsen-pgi
requested review from
smeenai and
bcardosolopes
and removed request for
bcardosolopes and
lanza
|
Awesome, thanks for the cleanup |
bcardosolopes
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class
CIRGenFunctioncontained three identical functions that converted from a Clang AST type (clang::QualType) to a ClangIR type (mlir::Type):convertType,ConvertType, andgetCIRType. This embarrassment of duplication needed to be fixed, along with cleaning up other functions that convert from Clang types to ClangIR types.The three functions
CIRGenFunction::ConvertType,CIRGenFunction::convertType, andCIRGenFunction::getCIRTypewere combined into a single functionCIRGenFunction::convertType. Other functions were renamed as follows:CIRGenTypes::ConvertTypetoCIRGenTypes::convertTypeCIRGenTypes::ConvertFunctionTypeInternaltoCIRGenTypes::convertFunctionTypeInternalCIRGenModule::getCIRTypetoCIRGenModule::convertTypeConstExprEmitter::ConvertTypetoConstExprEmitter::convertTypeScalarExprEmitter::ConvertTypetoScalarExprEmitter::convertTypeMany cases of
getTypes().convertType(t)andgetTypes().convertTypeForMem(t)were changed to justconvertType(t)andconvertTypeForMem(t), respectively, because the forwarding functions inCIRGenModuleandCIRGenFunctionmake the explicit call togetTypes()unnecessary.