Daily Candles Support

[Alium58]

Description

Put in uses for most daily candles. Added all candles to buffMaintain for potential future use.

Fixed formatting in buffMaintain. That was a single commit so you can review stand alone.

How Has This Been Tested?

Tested in run. Testing in progress. Box checked when confirmed working as intended in run.

Candles tested:

• Meat candle
• Not tested - Resistance candle
• Init candle
• Banana candle
• Stats per combat candle
• Stat buff candle
• MP cost reducing candle

Checklist:

• My code follows the style guidelines of this project.
• I have performed a self-review of my own code.
• I have commented my code, particularly in hard-to-understand areas.
• I have based by pull request against the master branch or have a good reason not to.

[quarklikeadork]

Ew, The Humanity lasts 40 turns can you know this won't mess with other zones? like bringing back banished pygmies as task orders change with some paths. or a more likely issue during the same quest with getting wet stew ingredients where this adds more [Knight in White Satin]

[Alium58]

Ew, The Humanity lasts 40 turns can you know this won't mess with other zones? like bringing back banished pygmies as task orders change with some paths. or a more likely issue during the same quest with getting wet stew ingredients where this adds more [Knight in White Satin]

Ah good point. I'll take it out

[quarklikeadork]

Ew, The Humanity still seems useful if Transcendent Olfaction and Red-Nosed Snapper aren't available
and there are only limited zones where adding dudes after Palindome would be bad, if autoscend can

• remove it before looking for fights in Hidden City, Whitey's Grove, Twin Peaks, The Penultimate Fantasy Airship if still looking to track quiet healer?
• and check before using humanity candle that it either won't need to remove the effect in softcore (other dude zones finished and can pull wet stew) or will be able to remove it and is able to remove Beaten Up without consuming the remover

could still be worth using

[Alium58]

We can check to see if we will have a way to remove the effect when we use the candle, but there is no guarantee we will still have that removal when we want it. Difficult to predict the future.

If whitey's grove wasn't part of this quest I'd say it is likely worth it to use human candle. However it is kind of a wash if we don't have a removal. Helps in palindome but hurts in whitey's grove.

I'll leave out for now and can be a future project if anyone wants it.

[quarklikeadork]

that is true, I think for now autoscend would only end up using removers for Beaten Up and Thrice-cursed but to be safe later it would need a whole system to reserve and unreserve them, becomes more trouble than it's worth

[Alium58]

Well tested and saw all candles work except the resistance one. My account has enough other res sources to not need it. I think I could use it on boo clues, but that does not use the ProvideResistance function... see issue #1103

So I'm going to say this one is good to go now.