Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use mall_price if historical_price of consumable is 0 #1126

Merged
merged 6 commits into from
May 17, 2022

Conversation

quarklikeadork
Copy link
Contributor

because historical_price can be 0 #1125 instead of just being outdated, more changes might be needed elsewhere for this.

this was already using mall_price in older versions and the change to historical price was meant to avoid new searches when a mafia session is restarted, though normally the prices of food and drink have been bulk searched and after that historical prices should not be 0, but if they are, 0 would definitely be wrong

How Has This Been Tested?

run and cli

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have based my pull request against the master branch or have a good reason not to.

@quarklikeadork quarklikeadork merged commit 880e4bc into loathers:master May 17, 2022
@quarklikeadork quarklikeadork deleted the historicalprice0check branch May 17, 2022 06:01
careyourcurroundings pushed a commit to careyourcurroundings/autoscend that referenced this pull request May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants