New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize fetch and upgrade polkadot #113

Merged

gdethier merged 2 commits into main from feature/optimize-requests

Mar 23, 2023

Contributor

gdethier commented Mar 23, 2023

Fetch vault and protection requests in a single call, then filter client-side.
Upgrade Polkadot JS, this lead to switch node-api to ESM. A current bug in typegen required an edit of the tool in node_modules, see this comment. A fix is underway, see this PR.
In consequence of the switch, node-api unit tests had to be adapted (see here).
client integration tests randomly crash (i.e. not on every run) with the recently detected decoding issue.

logion-network/logion-internal#828


          feat: optimize fetch and upgrade polkadot.

54fe7c3

logion-network/logion-internal#828

gdethier requested a review from benoitdevos

March 23, 2023 06:51

gdethier assigned gdethier and benoitdevos

gdethier changed the title ~~feat: optimize fetch and upgrade polkadot.~~ Optimize fetch and upgrade polkadot


          chore: fix CI.

15d14b6

benoitdevos approved these changes

View reviewed changes

Contributor

benoitdevos left a comment

Good job !!

gdethier merged commit ba7ffb6 into main

gdethier deleted the feature/optimize-requests branch

March 23, 2023 08:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet