Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for React Native support #205

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Prepare for React Native support #205

merged 1 commit into from
Nov 3, 2023

Conversation

gdethier
Copy link
Contributor

@gdethier gdethier commented Nov 2, 2023 •
edited
Loading

  • File access and upload are abstracted in client.
  • New client-node and client-browser workspaces were introduced to provide specific implementations for respectively Node.JS and browsers.
  • The integration tests are part of the client-node workspace as they rely on Node.JS.
  • The next step will be to introduce a client-react-native workspace for supporting React Native.
  • Adds missing MultiversX README.
  • Makes client a peer dependency in extensions workspaces in order to save some useless package publications on client-* updates (using this yarn feature, otherwise workspace dependency resolution does not work).
  • Adds clean script to all workspaces.

logion-network/logion-internal#1046

@gdethier gdethier requested a review from benoitdevos November 2, 2023 16:28
@gdethier gdethier force-pushed the feature/prepare-react-native branch from 93f8e96 to a119ae7 Compare November 3, 2023 07:31
@gdethier gdethier force-pushed the feature/prepare-react-native branch from a119ae7 to 3569d53 Compare November 3, 2023 07:36
benoitdevos
benoitdevos approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@benoitdevos benoitdevos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !
Really promising, looking forward the integration in front.

@gdethier gdethier merged commit e4db246 into main Nov 3, 2023
2 checks passed
@gdethier gdethier deleted the feature/prepare-react-native branch November 3, 2023 09:51
This was referenced Nov 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benoitdevos benoitdevos benoitdevos approved these changes

Assignees

@gdethier gdethier

@benoitdevos benoitdevos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdethier @benoitdevos