Merge pull request #94 from logion-network/feature/remove-loc-created

chore: remove template loc-created.
logion-network · Mar 7, 2022 · b8b574f · b8b574f
2 parents bfc4b0e + 3527724
commit b8b574f
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 40 deletions.
diff --git a/resources/mail/loc-created.pug b/resources/mail/loc-created.pug
diff --git a/src/logion/controllers/locrequest.controller.ts b/src/logion/controllers/locrequest.controller.ts
@@ -135,14 +135,9 @@ export class LocRequestController extends ApiController {
         await this.checkIdentityLoc(request.requesterIdentityLocId)
         await this.locRequestRepository.save(request);
         const userIdentity = await this.findUserIdentity(request);
-        if (userIdentity) {
-            if (authenticatedUser.isNodeOwner()) {
-                this.getNotificationInfo(request.getDescription(), userIdentity)
-                    .then(info => this.notificationService.notify(info.walletUserEmail, "loc-created", info.data))
-            } else {
-                this.getNotificationInfo(request.getDescription(), userIdentity)
-                    .then(info => this.notificationService.notify(info.legalOfficerEMail, "loc-requested", info.data))
-            }
+        if (!authenticatedUser.isNodeOwner() && userIdentity) {
+            this.getNotificationInfo(request.getDescription(), userIdentity)
+                .then(info => this.notificationService.notify(info.legalOfficerEMail, "loc-requested", info.data))
         }
         return this.toView(request, userIdentity);
     }

diff --git a/src/logion/services/notification.service.ts b/src/logion/services/notification.service.ts
@@ -16,7 +16,6 @@ export const templateValues = [
     "loc-requested",
     "loc-accepted",
     "loc-rejected",
-    "loc-created",
     "all-documented-vars"
 ] as const;
 

diff --git a/test/unit/controllers/locrequest.controller.spec.ts b/test/unit/controllers/locrequest.controller.spec.ts
@@ -126,10 +126,6 @@ describe('LocRequestController', () => {
                 expect(userIdentity.email).toBe("[email protected]");
                 expect(userIdentity.phoneNumber).toBe("+1234");
             });
-
-        notificationService.verify(instance => instance.notify("[email protected]", "loc-requested", It.Is<any>(data => {
-            return data.loc.locType === locType
-        })))
     }
 
     it('succeeds to create a Transaction loc request with embedded user identity', async () => {
@@ -162,10 +158,6 @@ describe('LocRequestController', () => {
                 expect(userIdentity.email).toBe("[email protected]");
                 expect(userIdentity.phoneNumber).toBe("+6789");
             });
-
-        notificationService.verify(instance => instance.notify(testUserIdentity.email, "loc-created", It.Is<any>(data => {
-            return data.loc.locType === locType
-        })))
     }
 
     it('succeeds to create open Transaction loc with existing protection request', async () => {
@@ -198,10 +190,6 @@ describe('LocRequestController', () => {
                 expect(userIdentity.email).toBe("[email protected]");
                 expect(userIdentity.phoneNumber).toBe("+1234");
             });
-
-        notificationService.verify(instance => instance.notify("[email protected]", "loc-created", It.Is<any>(data => {
-            return data.loc.locType === locType
-        })))
     }
 
     it('succeeds to create open Transaction loc with embedded user identity', async () => {
@@ -236,10 +224,6 @@ describe('LocRequestController', () => {
                 expect(userIdentity.email).toBe("[email protected]");
                 expect(userIdentity.phoneNumber).toBe("+0101");
             });
-
-        notificationService.verify(instance => instance.notify("[email protected]", "loc-created", It.Is<any>(data => {
-            return data.loc.locType === "Transaction"
-        })))
     });
 
     async function testLocRequestCreation(locType: LocType) {
@@ -268,6 +252,7 @@ describe('LocRequestController', () => {
         notificationService.verify(instance => instance.notify("[email protected]", "loc-requested", It.Is<any>(data => {
             return data.loc.locType === locType
         })))
+
     }
 
     it('succeeds to create Transaction loc request with existing protection request', async () => {