Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't lose pending jobs in case of unclean exit #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Don't lose pending jobs in case of unclean exit #33

wants to merge 2 commits into from

Conversation

gashtal
Copy link

@gashtal gashtal commented Feb 20, 2024

Ensure all pending jobs are retained in case the application is not closed cleanly for any reason:

  • Clear job queue file only at exit, and only if the user chooses not to save the queue.
  • Immediately save the queue to file when a job is added or removed, to prevent the changes from being lost in case of unclean exit. Queue file will still be cleared if user chooses to do so when closing the application.

@gashtal
Clear queue only on application close, and only if user chooses to do so
aeeb707 
Ensures that existing jobs in the queue are not lost if the application is not closed cleanly for any reason
@gashtal
Update queue file whenever a job is added or removed
0b56e92 
Ensures jobs added or removed during the current session get immediately saved in queue.ini and won't be lost if the application is not closed cleanly
@MRos7909
Copy link

@lordmulder, can you include this PR in the next release too? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gashtal @MRos7909