beta waitlist #3
Conversation
refactor queue
| @@ -0,0 +1,13 @@ | |||
| require 'clockwork' | |||
There was a problem hiding this comment.
have we considered using periodical, which is already built in?
There was a problem hiding this comment.
no, but only because not familiar with it.
embarassed--google search coming up dry. can you add link?
There was a problem hiding this comment.
| require './config/boot' | ||
| require './config/environment' | ||
|
|
||
| include Clockwork |
There was a problem hiding this comment.
please ensure we're logging to a place that gets rotated (such as log/production.log)
| end | ||
| end | ||
|
|
||
| def add |
There was a problem hiding this comment.
do we want to consider RESTful routes? I think add and remove make sense, but i'm just asking if we have strong opinions either way
| end | ||
|
|
||
| def add | ||
| Rails.logger.warn("current_waitlist: #{current_waitlist.list}") |
There was a problem hiding this comment.
this is good for our debugging, but in a PR to zendesk, i would advise making this debug
|
|
||
| #Samson::Hooks.view :stage_form, '<view path>' | ||
|
|
||
| Samson::Hooks.view :stage_show, 'samson_deploy_waitlist/deployers' |
There was a problem hiding this comment.
lets remove the stuff we're not actively using. They'll be potentially out of date with newer versions
| next if s.lock.try(:user).try(:email) == current_head[:email] | ||
| next unless TIME_TO_LOCK_QUEUE.minutes.ago > waitlist.head_updated_at.to_datetime | ||
|
|
||
| # Current head of waitlist has been head for 5 minutes without locking the stage... |
| TIME_TO_LOCK_QUEUE = 10 | ||
|
|
||
| def self.check_your_head | ||
| Stage.all.each do |s| |
There was a problem hiding this comment.
please use stage as your iterator unless there's a better name for style
|
|
||
| current_head = waitlist.list[0] | ||
|
|
||
| next if s.lock.try(:user).try(:email) == current_head[:email] |
There was a problem hiding this comment.
this is already bound to ruby > 2.4. You can use a safe operator
next if s.lock&.user&.email == current_head[:email]
|
Do we care about this? It might need a rebase due to the pull from upstream zendesk into master. |
|
👋 |
Simple first implementation of in situ deployment waitlist for deploying to a stage
Tasks
References
Risks