Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data processing datasources #1009

Closed
wants to merge 1 commit into from

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 1, 2023

This change removes data sources from Grafana for the old data-processing cluster. The clusters and DNS names have all been removed from all projects.

Part of:

This change is Reviewable

@stephen-soltesz
Copy link
Contributor Author

I stopped the build to prevent stepping on other changes in sandbox. I won't merge until it's been deployed and verified in sandbox.

@nkinkade IIRC, there are manual steps to delete data sources (is that correct?)

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The official way to delete a provisioned datasource is by adding the datasource to a special config array that Grafana reads:

https://grafana.com/docs/grafana/latest/administration/provisioning/#data-sources

You can add the datasources to this file:

https://github.com/m-lab/prometheus-support/blob/main/config/federation/grafana/provisioning/datasources/deleted.yml

The unofficial way is outlined in the README:

https://github.com/m-lab/prometheus-support#deleting-provisioned-datasources

:lgtm:, when you are ready to merge.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz
Copy link
Contributor Author

Obsolete by: #1010

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants