Update min/max node counts for parser and prometheus #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkinkade
approved these changes
Aug 24, 2023
There was a problem hiding this comment.
max_node_count from 2 to 3 for the parser node pool help with it not being able to create 8 new nodes?
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 1 approvals obtained
stephen-soltesz
commented
Aug 24, 2023
There was a problem hiding this comment.
Yes, there are three zones per cluster (or node pool) and these autoscaling min/max values appear to apply to each zone. So max 3 nodes * 3 zones is up to 9 nodes. There are 8 in sandbox now for the parser node pool.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the min or max node counts used by the parser and prometheus node pools in the new data-pipeline cluster. The parser default prevented 8 nodes from being created for all parsers, and the prometheus default required wasted nodes. Ideally we want one spare, but two spares is a waste.
Part of:
This change is