fix: Remove slugify dependency #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closing and reopening to re-run checks |
rmi22186
reviewed
Oct 11, 2023
src/utils.ts
Outdated
| // TODO: Refactor this to a regex | ||
| const isDataPlanSlug = (str: string): boolean => | ||
| isString(str) && str === slugify(str); | ||
| const toSlug = (value: any): string => |
There was a problem hiding this comment.
Technically these are not slugs, because slugs can have hyphens. I think we should really call this something more specific to our purposes. I see the backend uses the term PlanSlug, which because it's in a file named DataPlan might make sense, so I think the following is a goodr renaming:
Suggested change
| const toSlug = (value: any): string => | |
| const toDataPlanSlug = (value: any): string => |
rmi22186
reviewed
Oct 11, 2023
src/utils.ts
Outdated
| .replace(/[^0-9a-zA-Z]+/g, '_') | ||
| : ''; | ||
|
|
||
| const isDataPlanSlug = (str: string): boolean => str === toSlug(str); |
There was a problem hiding this comment.
Suggested change
| const isDataPlanSlug = (str: string): boolean => str === toSlug(str); | |
| const isDataPlanSlug = (str: string): boolean => str === toDataPlanSlug(str); |
rmi22186
requested changes
Oct 11, 2023
rmi22186
requested changes
Oct 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
rmi22186
approved these changes
Oct 17, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2023
## [2.23.6](v2.23.5...v2.23.6) (2023-10-17) ### Bug Fixes * Remove slugify dependency ([#786](#786)) ([8346bdc](8346bdc))
|
🎉 This PR is included in version 2.23.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Slugifywithout using any polyfills or JS functions that are incompatible with ES5.Testing Plan
Invalid Data Plan Slug
Valid Data Plan Slug
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)