Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Browserstack GIthub workflow #798

Merged

Conversation

rmi22186
Copy link
Member

@rmi22186 rmi22186 commented Nov 9, 2023

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

This PR sets up Browserstack tests in a Github Action. It follows the example workflow provided by the Browserstack docs here - https://www.browserstack.com/docs/automate/selenium/github-actions#sample-github-workflow-showing-a-browserstack-test

We originally discussed having it only be on release. However, I think it makes sense for it to be on push/pr also because we wouldn't want something to pass our non-CBT tests, merge them in, then upon release see that something is broken. Given that it is its own workflow, and our workflow minutes are unlimited for public repos, I see no issue with this. Note that this successfully runs here (although there are some failed tests, Chrome 48 tests here fail a few in the GHA, which matches the locally run Browserstack npm task, and Chrome 49 simply has a failed flaky test):

Testing Plan

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

Copy link
Collaborator

@alexs-mparticle alexs-mparticle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but you should make sure your tests are passing before you merge it in.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rmi22186 rmi22186 merged commit ff6c8a7 into ci/SQDSDKS-5780-cross-browser-testing Nov 15, 2023
27 of 28 checks passed
@rmi22186 rmi22186 deleted the ci/SQDSDKS-5792-cbt-GHA branch November 17, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants