feat: Hash keys for idCache #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexs-mparticle
approved these changes
Jan 23, 2024
src/identity-utils.ts
Outdated
| @@ -62,7 +63,7 @@ export const cacheIdentityRequest = ( | |||
| const cache: Dictionary<ICachedIdentityCall> = idCache.retrieve() || ({} as Dictionary<ICachedIdentityCall>); | |||
| const cacheKey = concatenateIdentities(method, identities); | |||
|
|
|||
| cache[cacheKey] = { responseText: xhr.responseText, status: xhr.status, expireTimestamp}; | |||
| cache[generateHash(cacheKey)] = { responseText: xhr.responseText, status: xhr.status, expireTimestamp}; | |||
There was a problem hiding this comment.
I think this should be split into two lines for readability.
|
alexs-mparticle
approved these changes
Jan 23, 2024
rmi22186
merged commit 546235e
into
feat/SQDSDKS-5976-identity-caching-feature-branch
25 of 28 checks passed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
Hash the concatenated identities.
Testing Plan
Unit tests
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)