Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Google Click Ids #955

Merged
merged 2 commits into from
Dec 5, 2024
Merged

feat: Add support for Google Click Ids #955

merged 2 commits into from
Dec 5, 2024

Conversation

alexs-mparticle
Copy link
Collaborator

Instructions

  1. PR target branch should be against development
  2. PR title name should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-title-check.yml
  3. PR branch prefix should follow this format: https://github.com/mParticle/mparticle-workflows/blob/main/.github/workflows/pr-branch-check-name.yml

Summary

  • Add support for Google Click Ids

Testing Plan

  • Was this tested locally? If not, explain why.
  • Run through automated tests. Manually configure sample app to use Integration Capture setting in backend and add relevant gclid, gbraid, wbraid values to query parameters.

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@alexs-mparticle alexs-mparticle changed the base branch from development to feat/click-ids December 4, 2024 19:17
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
38.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@alexs-mparticle alexs-mparticle merged commit f6ba224 into feat/click-ids Dec 5, 2024
20 of 28 checks passed
alexs-mparticle added a commit that referenced this pull request Dec 11, 2024
@alexs-mparticle
feat: Add support for Google Click Ids (#955) (#957)
f03c5ed
rmi22186 pushed a commit that referenced this pull request Dec 11, 2024
@alexs-mparticle @rmi22186
feat: Add support for Google Click Ids (#955) (#957)
3df8d84
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
@mparticle-automation
chore(release): 2.31.0 [skip ci]
bb63c83 
# [2.31.0](v2.30.4...v2.31.0) (2024-12-11)

### Features

* Add support for Google Click Ids ([#955](#955)) ([#957](#957)) ([3df8d84](3df8d84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmi22186 rmi22186 rmi22186 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexs-mparticle @rmi22186