Repository navigation
Stream HTTP request bodies for large file uploads - #663
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The HTTP client currently requires the whole upload body in a string and copies it into the serialized request. Add a known-length streaming body so applications can upload files larger than 2 GiB with bounded client buffering.
HttpRequestArgs::bodySize(uint64_t) andonUploadCallback(offset, buffer, capacity), then pass an empty string body to POST/PUT/PATCH orrequest. The callback fills a reusable buffer of at most 64 KiB; requests use ordinaryContent-Lengthframing.This addresses client-side uploads in #556. Chunked request encoding (#381) is separate and unnecessary when the body length is known. Server-side request parsing and the existing multipart form helpers still buffer their complete bodies.
Validation:
-pedantic-errors, formatting andgit diff --checkpass.Closes #556.