Repository navigation
Reuse persistent HTTP client connections - #665
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated requests through one
HttpClientcurrently tear down and recreate TCP/TLS connections. Retain one fully consumed HTTP/1.1 connection and reuse it for sequential requests to the same origin, including queued asynchronous requests and same-origin redirects.Connection: closetokens in either direction. Preserve repeated framing/connection fields rather than silently overwriting them; WebSocket handshake validation accepts the resulting Connection token lists. Ambiguous framing is never cached.HttpServeradvertiseConnection: closeduring serialization, without mutating application-owned response objects. Update one-shot test fixtures likewise.No new client settings are needed. This retains one idle connection rather than adding a connection pool or pipelining. HTTP-to-WebSocket ownership transfer remains separate (#434).
Validation:
-Werror=deprecated-declarations), mbedTLS 3 under ThreadSanitizer, and TLS/zlib disabled.-pedantic-errors, formatting and whitespace checks pass.Fixes #484.