Avoid failures when other runners are already registered with same name #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid failures when other runners are already registered with same name
|
this is awesome and was also causing us problems. |
drashy
pushed a commit
to drashy/ec2-github-runner
that referenced
this pull request
Feb 24, 2023
johnsonrw82
added a commit
to physion/ec2-github-runner
that referenced
this pull request
Apr 17, 2023
|
Awesome fix! I am facing this problem right now on my builds... When this PR will be merged? |
It looks like it won't be that soon. If it helps we are using it like that: - name: Start EC2 runner
uses: kimetrica/ec2-github-runner@set-unique-name-in-UserData-script |
|
We are also running in the same issue, it would be great to see this merged soon |
romeroyonatan
added a commit
to Shiphero/ec2-github-runner
that referenced
this pull request
Aug 8, 2024
romeroyonatan
added a commit
to Shiphero/ec2-github-runner
that referenced
this pull request
Aug 8, 2024
romeroyonatan
added a commit
to Shiphero/ec2-github-runner
that referenced
this pull request
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we were running into issues where newly created instances weren't able to register with Github as runners, because by default the hostname is used as
--name, and AWS was reusing hostnames from our IP range.This can be fixed by setting the name explicitly, to something that is unique.
I think
--name $(hostname)-$(uuidgen)should work well.Fixes #128