Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove madara and pathfinder submodules #194

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

notlesh
Copy link
Collaborator

@notlesh notlesh commented Dec 18, 2024

This PR removes the madara and pathfinder git submodules.

@coveralls
Copy link

coveralls commented Dec 18, 2024

Coverage Status

coverage: 67.892%. remained the same
when pulling b534e00 on notlesh/remove-submodules
into 9e67649 on main.

@apoorvsadana
Copy link
Contributor

apoorvsadana commented Dec 23, 2024

@notlesh do we want to remove this right now or when we're moving everything to a monorepo? Removing this right now will also need us to modify the Makefile

@notlesh
Copy link
Collaborator Author

notlesh commented Dec 23, 2024

@notlesh do we want to remove this right now or when we're moving everything to a monorepo? Removing this right now will also need us to modify the Makefile

I think it's fine to wait. I opened this mostly to see if CI would fail (and that would help me understand why the submodules existed in the first place.)

What would need to change about the Makefile? At first glance, it looks like it uses Madara through Docker.

Edit: The Makefile uses the submodule here: https://github.com/madara-alliance/madara-orchestrator/blob/main/Makefile#L149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants