Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 3A Nue Smart AC Fan 3 Speed & Lamp Controller #2737

Merged
merged 8 commits into from
Jan 11, 2025
Merged

Add 3A Nue Smart AC Fan 3 Speed & Lamp Controller #2737

merged 8 commits into from
Jan 11, 2025

Conversation

vytux-com
Copy link
Contributor

#2733 Add support for 3A Nue Smart AC Fan 3 Speed & Lamp Controller

@vytux-com
Copy link
Contributor Author

@make-all not quite sure what the test failure means.... sorry.

=========================== short test summary info ============================
FAILED tests/test_device_config.py::TestDeviceConfig::test_config_files_parse - AssertionError: Validation error in nue_smart_fan_3speed_light.yaml: extra keys not allowed @ data['primary_entity']
========================= 1 failed, 25 passed in 5.87s =========================

@vytux-com
Copy link
Contributor Author

Is this something very new? As I tried that before creating this PR and I was getting an error stating that the primary entity is missing.

Unless this is to be changed in the upcoming release?

@make-all
Copy link
Owner

make-all commented Jan 5, 2025

Yes, it is in the upcoming release. The old configs will work (with deprecation warnings), but the CI is no longer considering the old format valid because the ones in the repository should be updated to the new format already.

@make-all
Nue smart fan: naming change
f4e117a 
- do not duplicate name under products.
- shorten name as it is prepended to entities in various places in the UI.

PR make-all#2737
@make-all
Merge branch 'main' into main
3cbea28
@make-all
Nue fan and light: split timer into separate entities.
766d8ad 
PR make-all#2737
make-all added a commit that referenced this pull request Jan 11, 2025
@make-all
Docs for PR #2737
433acf2
@make-all make-all merged commit 7568ff5 into make-all:main Jan 11, 2025
4 checks passed
make-all added a commit that referenced this pull request Jan 11, 2025
@make-all
Nue fan: update to use new entities list
b2f7c0f 
PR #2737
make-all added a commit that referenced this pull request Jan 11, 2025
@make-all
Nue smart fan: naming change
17c68a7 
- do not duplicate name under products.
- shorten name as it is prepended to entities in various places in the UI.

PR #2737
make-all added a commit that referenced this pull request Jan 11, 2025
@make-all
Nue fan and light: split timer into separate entities.
e5cf9d9 
PR #2737
make-all added a commit that referenced this pull request Jan 11, 2025
@make-all
Docs for PR #2737 (prev was actually #2728)
8f5ff38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Tuya Local
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vytux-com @make-all