Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF version 1.14.0 (almost works locally) #512

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PallHaraldsson
Copy link
Contributor

No description provided.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Aug 14, 2019

I just noticed there was an upgrade. Possibly some more is needed, since this is a major(?) upgrade, why I didn't put in "skip ci". I'm just going by last change I saw, that was actually a (temporary) downgrade.

I don't need this myself.

OCaml wrapper is up to date, and I see it took a larger jump (and seemingly no changes needed, only one what seems to be for OCaml not TF):

LaurentMazare/tensorflow-ocaml@e195f91

@malmaud
Copy link
Owner

malmaud commented Aug 15, 2019

Thanks! Looks like CI failed, though - maybe something with the packaging of the upstream TensorFlow binaries has changed.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Aug 16, 2019

"maybe something with the packaging of the upstream TensorFlow binaries has changed."

To compare I looked at commits for OCaml (I would have thought less used the Julia). there only the download links in the README where updated; but you have to get the build system and compile yourself.

It seems they use C++ [API] (I know you do not; as other recommended), while not obvious where (I see C++ only in "Use TensorFlow C++ based gradient computation"):

LaurentMazare/tensorflow-ocaml@12730d8

@PallHaraldsson
Copy link
Contributor Author

Less urgent than #513

@chengchingwen
Copy link

Any update? Looks like the CI failed because it cannot find the shared library.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Feb 20, 2020

Any update?

Not from me (should be simple though, or to support 1.15.2), see full answer at #513

@PallHaraldsson PallHaraldsson changed the title TF version 1.14.0 TF version 1.15.2 Feb 20, 2020
@PallHaraldsson
Copy link
Contributor Author

I do also expect 1.15.2 to fail. Just changed PR to check.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Mar 2, 2020

Hi, @oxinabox (and @chengchingwen) is 12.x really needed or 14.0 (or something newer), what I seemingly got to work, ok for you?

I got it to work locally, with:

(v1.3) pkg> dev TensorFlow

shell> pip3 install --upgrade tensorflow

[only gets 1.14.0]

(v1.3) pkg> build TensorFlow

1.14 (and 1.15.2) do not work here on GitHub, as the library is missing, which I found out how to fix, but only locally, and so far not newer than 1.14.0.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Mar 2, 2020

pip3 install -U pip

seemingly works (a TF 2 requirement to have pip >19) for conda to download TF 2.1.0

however, in the code this link gets generated and fails https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-2.1.0.tar.gz

neither does this one work
https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-1.15.2.tar.gz

But slightly older I seemingly get to build as it downloads:
https://storage.googleapis.com/tensorflow/libtensorflow/libtensorflow-cpu-linux-x86_64-1.15.0.tar.gz

@PallHaraldsson PallHaraldsson changed the title TF version 1.15.2 TF version 1.14.0 (should work locally) Mar 2, 2020
@oxinabox
Copy link
Collaborator

oxinabox commented Mar 2, 2020

Hi, @oxinabox (and @chengchingwen) is 12.x really needed or 14.0 (or something newer), what I seemingly got to work, ok for you?

1.14.0 is preferred over 1.12.x if you can get it to work.
But it needs to pass CI.
I do not at present have time to dig into why it might not pass CI.

@PallHaraldsson
Copy link
Contributor Author

PallHaraldsson commented Mar 2, 2020

I found out why only the build.jl worked. Before there was only a .so file of each, now it's a links (and links to links) of both:

/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow_framework.so
/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow_framework.so.1
/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow_framework.so.1.14.0
/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow_framework.so.1.15.0
/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow.so
/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow.so.1
/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow.so.1.14.0
/home/pharaldsson_sym/.julia/dev/TensorFlow/deps/downloads/lib/libtensorflow.so.1.15.0

@PallHaraldsson PallHaraldsson changed the title TF version 1.14.0 (should work locally) TF version 1.14.0 (almost works locally) Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants