fix & simplify tests

tests/db_test_helper.py

@@ -40,3 +40,18 @@ def _test_sqlalchemy(db):
         # the SELECT of a scalar value without a table is
         # appropriately formatted for the backend
         assert conn.scalar(select(1)) == 1
+
+def _test_connect(db):
+    connection = db.connect()
+    cursor = connection.cursor()
+    try:
+        cursor.execute('SELECT 1')
+        row = cursor.fetchone()
+        assert row[0] == 1
+        connection.commit()
+    except Exception as e:
+        connection.rollback()
+        raise e
+    finally:
+        cursor.close()
+        connection.close()

tests/mssql/test_mssql.py

@@ -60,19 +60,8 @@ def test_mssql_connect(mssql_db):
     """
     A simple test to check if the connect API works.
     """
-    connection = MSSQL_DB.connect()
-    cursor = connection.cursor()
-    try:
-        cursor.execute('SELECT 1')
-        row = cursor.fetchone()
-        assert row[0] == 1
-        connection.commit()
-    except Exception as e:
-        connection.rollback()
-        raise e
-    finally:
-        cursor.close()
-        connection.close()
+    from ..db_test_helper import _test_connect
+    _test_connect(mssql_db)
 
 
 

tests/postgres/test_postgres.py

@@ -156,16 +156,5 @@ def test_postgres_connect(postgres_db):
     """
     A simple test to check if the connect API works.
     """
-    connection = POSTGRES_DB.connect()
-    cursor = connection.cursor()
-    try:
-        cursor.execute('SELECT 1')
-        row = cursor.fetchone()
-        assert row[0] == 1
-        connection.commit()
-    except Exception as e:
-        connection.rollback()
-        raise e
-    finally:
-        cursor.close()
-        connection.close()
+    from ..db_test_helper import _test_connect
+    _test_connect(postgres_db)

tests/test_databricks.py

@@ -47,16 +47,5 @@ def test_databricks_connect():
     """
     A simple test to check if the connect API works.
     """
-    connection = DATABRICKS_DB.connect()
-    cursor = connection.cursor()
-    try:
-        cursor.execute('SELECT 1')
-        row = cursor.fetchone()
-        assert row[0] == 1
-        connection.commit()
-    except Exception as e:
-        connection.rollback()
-        raise e
-    finally:
-        cursor.close()
-        connection.close()
+    from .db_test_helper import _test_connect
+    _test_connect(DATABRICKS_DB)