-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: try adding gh profile lists to team page #41
base: master
Are you sure you want to change the base?
Conversation
WalkthroughThis pull request adds GitHub profile links to team member profile pages for five team members: Emile Fugulin, Renzo Tomlinson, Veronika Gnilitska, Weston Platter, and Yangci Ou. The changes involve updating the metadata in individual Markdown files to include a new Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for masterpoint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh cool! Preview looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
layouts/shortcodes/team.html (1)
24-26
: Add security and accessibility attributes to external links.While the implementation is correct, consider adding security and accessibility improvements:
- <div class="teamSocial"><a href="{{.Params.github}}" target="_blank"><i class="fa-brands fa-github"></i></a></div> + <div class="teamSocial"><a href="{{.Params.github}}" target="_blank" rel="noopener noreferrer" aria-label="GitHub Profile"><i class="fa-brands fa-github"></i></a></div>These changes will:
- Prevent potential security vulnerabilities with
rel="noopener noreferrer"
- Improve accessibility with
aria-label
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
content/team/emile-fugulin.md
(1 hunks)content/team/renzo-tomlinson.md
(1 hunks)content/team/veronika-gnilitska.md
(1 hunks)content/team/weston-platter.md
(1 hunks)content/team/yangci-ou.md
(1 hunks)layouts/shortcodes/team.html
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- content/team/veronika-gnilitska.md
🔇 Additional comments (4)
content/team/emile-fugulin.md (1)
5-5
: LGTM! GitHub profile link added correctly.The GitHub profile URL is valid and properly formatted.
content/team/yangci-ou.md (1)
5-5
: LGTM! GitHub profile link added correctly.The GitHub profile URL is valid and properly formatted.
content/team/renzo-tomlinson.md (1)
5-5
: LGTM! GitHub profile link added correctly.The GitHub profile URL is valid and properly formatted.
content/team/weston-platter.md (1)
5-5
: LGTM! GitHub profile link added correctly.The GitHub profile URL is valid and properly formatted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it ❤️
Is everyone else (@Sytten, @gberenice, @rttomlinson) cool with the mastepoint website display links to your github profiles? |
Summary by CodeRabbit