Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: try adding gh profile lists to team page #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

westonplatter
Copy link
Member

@westonplatter westonplatter commented Jan 15, 2025

Summary by CodeRabbit

  • New Features
    • Added GitHub profile links for team members: Emile Fugulin, Renzo Tomlinson, Veronika Gnilitska, Weston Platter, and Yangci Ou
    • Enhanced team member profiles with clickable GitHub and LinkedIn social media icons

Copy link

coderabbitai bot commented Jan 15, 2025

Walkthrough

This pull request adds GitHub profile links to team member profile pages for five team members: Emile Fugulin, Renzo Tomlinson, Veronika Gnilitska, Weston Platter, and Yangci Ou. The changes involve updating the metadata in individual Markdown files to include a new github field with their respective GitHub profile URLs. Additionally, the layouts/shortcodes/team.html template was modified to render GitHub profile icons as clickable links when a GitHub URL is present.

Changes

File Change Summary
content/team/emile-fugulin.md Added GitHub profile link: github: https://github.com/Sytten
content/team/renzo-tomlinson.md Added GitHub profile link: github: https://github.com/rttomlinson
content/team/veronika-gnilitska.md Added GitHub profile link: github: https://github.com/gberenice
content/team/weston-platter.md Added GitHub profile link: github: https://github.com/westonplatter
content/team/yangci-ou.md Added GitHub profile link: github: https://github.com/oycyc
layouts/shortcodes/team.html Updated to conditionally render GitHub and LinkedIn social media icons as clickable links

Possibly related PRs

Suggested reviewers

  • Gowiem

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for masterpoint ready!

Name Link
🔨 Latest commit ca5605b
🔍 Latest deploy log https://app.netlify.com/sites/masterpoint/deploys/678803e4b044990008186fdc
😎 Deploy Preview https://deploy-preview-41--masterpoint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 46
Accessibility: 89
Best Practices: 83
SEO: 80
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

oycyc
oycyc previously approved these changes Jan 15, 2025
Copy link
Contributor

@oycyc oycyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh cool! Preview looks good.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
layouts/shortcodes/team.html (1)

24-26: Add security and accessibility attributes to external links.

While the implementation is correct, consider adding security and accessibility improvements:

-                        <div class="teamSocial"><a href="{{.Params.github}}" target="_blank"><i class="fa-brands fa-github"></i></a></div>
+                        <div class="teamSocial"><a href="{{.Params.github}}" target="_blank" rel="noopener noreferrer" aria-label="GitHub Profile"><i class="fa-brands fa-github"></i></a></div>

These changes will:

  1. Prevent potential security vulnerabilities with rel="noopener noreferrer"
  2. Improve accessibility with aria-label
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7271e21 and ca5605b.

📒 Files selected for processing (6)
  • content/team/emile-fugulin.md (1 hunks)
  • content/team/renzo-tomlinson.md (1 hunks)
  • content/team/veronika-gnilitska.md (1 hunks)
  • content/team/weston-platter.md (1 hunks)
  • content/team/yangci-ou.md (1 hunks)
  • layouts/shortcodes/team.html (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • content/team/veronika-gnilitska.md
🔇 Additional comments (4)
content/team/emile-fugulin.md (1)

5-5: LGTM! GitHub profile link added correctly.

The GitHub profile URL is valid and properly formatted.

content/team/yangci-ou.md (1)

5-5: LGTM! GitHub profile link added correctly.

The GitHub profile URL is valid and properly formatted.

content/team/renzo-tomlinson.md (1)

5-5: LGTM! GitHub profile link added correctly.

The GitHub profile URL is valid and properly formatted.

content/team/weston-platter.md (1)

5-5: LGTM! GitHub profile link added correctly.

The GitHub profile URL is valid and properly formatted.

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it ❤️

@westonplatter
Copy link
Member Author

Is everyone else (@Sytten, @gberenice, @rttomlinson) cool with the mastepoint website display links to your github profiles?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants