Skip to content
This repository was archived by the owner on Sep 17, 2026. It is now read-only.

Fix incorrect GPO policy name for desktop auto-updater - #9164

Merged
hanzei merged 1 commit into
masterfrom
fix-desktop-autoupdater-policy-name
Sep 2, 2026
Merged

hanzei merged 1 commit into
masterfrom
fix-desktop-autoupdater-policy-name

Conversation

@hanzei

@hanzei hanzei commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The Windows GPO/registry value that controls the desktop app's auto-updater is EnableAutoUpdater (see resources/windows/gpo/mattermost.admx and policyConfigLoader.ts in mattermost/desktop), not EnableAutoUpdates.
  • Fixes the incorrect name in the group policy table and related references.

Test plan

  • Docs-only change; verified no other occurrences of EnableAutoUpdates remain in the repo

The registry/GPO value is EnableAutoUpdater (per resources/windows/gpo/mattermost.admx and policyConfigLoader.ts in mattermost/desktop), not EnableAutoUpdates.
@hanzei
hanzei requested a review from devinbinnie September 1, 2026 10:40
@hanzei hanzei added the 1: Dev Review Requires review by a core commiter label Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 816d5f64-345a-487d-a61c-b34a2e4566d9

📥 Commits

Reviewing files that changed from the base of the PR and between a030058 and bdf99f3.

📒 Files selected for processing (2)
  • source/deployment-guide/desktop/desktop-msi-installer-and-group-policy-install.rst
  • source/deployment-guide/desktop/desktop-troubleshooting.rst

Included review availability: 4 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.


📝 Walkthrough

Walkthrough

The desktop deployment and troubleshooting guides now use EnableAutoUpdater instead of EnableAutoUpdates for the Group Policy setting that controls update notifications.

Changes

Desktop Group Policy documentation

Layer / File(s) Summary
Correct Group Policy references
source/deployment-guide/desktop/desktop-msi-installer-and-group-policy-install.rst, source/deployment-guide/desktop/desktop-troubleshooting.rst
Updated deployment, multi-view configuration, and troubleshooting instructions to reference EnableAutoUpdater.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to bdf99

This documentation-only change corrects the desktop auto-updater policy name and introduces no actionable merge-blocking risk beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly and concisely identifies the correction to the desktop auto-updater GPO policy name.
Description check ✅ Passed The description accurately explains the GPO value correction and identifies the affected documentation references.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-desktop-autoupdater-policy-name

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA bdf99f3

@devinbinnie devinbinnie added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Newest code from mattermost has been published to preview environment for Git SHA bdf99f3

@hanzei
hanzei merged commit 78fe71c into master Sep 2, 2026
8 checks passed
@hanzei
hanzei deleted the fix-desktop-autoupdater-policy-name branch September 2, 2026 07:17
esarafianou added a commit to mattermost/mattermost that referenced this pull request Sep 3, 2026
Rename EnableAutoUpdates to EnableAutoUpdater to match the actual Group Policy exposed by the desktop app.

Ports mattermost/docs#9164.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

3: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants